feat: allow passing of custom URLs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Not tested yet! |
Owner
|
I think this currently prevents Could you instead do |
Owner
|
Might it also make more sense to keep the real URLs but mock at the HTTP request level, with something like |
g-sam
force-pushed
the
master
branch
2 times, most recently
from
5295380 to
db81e63
Compare
Author
|
Updated and tested indirectly in our tests. We thought nock might be rather complicated due to the various redirects (since this is for browser testing in Testcafe), but if you fancy doing a trial implementation would be interested to see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to mock orcid with our own service.